Feat haiti identity card and mobile phone support#2801
Open
SarthakDudhe wants to merge 7 commits into
Open
Conversation
…trailing zeros on 1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2591 +4
Branches 656 656
=========================================
+ Hits 2587 2591 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a short description of the changes:
isIdentityCard: Added support for Haiti (ht-HT), validating CIN cards (1 uppercase letter followed by 10 digits).
isMobilePhone: Added support for Haiti (ht-HT) mobile numbers, validating optional +509 followed by 8 digits (starting with 2, 3, or 4).
Documentation & Tests: Updated README.md to list ht-HT under both validators, and added corresponding unit tests in test/validators.test.js.